fix: Support custom error format for Route53 ChangeResourceRecordSets operation #791
Conversation
|
This PR is targeting the |
| renderCustomInvalidBatchError(writer) | ||
| renderInvalidChangeBatch(writer) |
There was a problem hiding this comment.
It would be awesome to have a way to just write this in swift, since it isn't dependent on the smithy model.
I filed this issue to investigate some mechanism that would allow us to write service specific swift code. I imagine the solution here will be related (if not the same) as solving the service specific integration test problem.
| } | ||
|
|
||
| private fun renderCustomInvalidBatchError(writer: SwiftWriter) { | ||
| writer.openBlock("struct CustomInvalidBatchError: Decodable {", "}") { |
There was a problem hiding this comment.
public APIs/structs must have docs.
There was a problem hiding this comment.
This isn't public. This is just internal as it's just used for decoding and then it's transformed into a InvalidChangeBatch instance.
|
LGTM, just small comment on docs. |
This PR adds support for a custom error format that is sometimes returned by the
ChangeResourceRecordSetsoperation in the Route53 service.The custom error looks something like the following:
Issue #
#214
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.